[3.x] Refactor ServiceConfig::class
.
#81
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What the diff?
This Pull Request primarily consists of updates and changes related to a software component we use to configure settings for various services,
ServiceConfig
. The significant changes are as follows:Change in File Library Imports
Across multiple files, we updated where
ServiceConfig
is imported from, changing it from theFluent
subdirectory to the primaryOrchestration
directory. This would ensure we're all using the latest version ofServiceConfig
for our settings.Use of Index-based Option Selection
In the
OrchestrateProvider.php
file, the method of option selection was changed to use the index of the option rather than its value. This was done to provide a more standardized and error-free way of choosing settings.Variables Assignment Update
The
OrchestrateService.php
file introduced assignment expressions for improving the way we define and assign values to certain variables like$name
and$id
.Standardization of Settings Retrieval
Methods for settings retrieval(
get
method) were used more extensively in files likeOrchestrateProvider.php
andDatabaseDriver.php
, providing a more standardized way to get the selected option's values.Creation of New Source Files
Two new files
ServiceConfig.php
andServiceDriver.php
were added to thesrc
directory. These files are likely to include the updated configuration options and functionalities we're adopting, creating a better-organized codebase.Modification in Test Files
Multiple testing files were updated to import the new
ServiceConfig
path. This ensures our test suites are in alignment with the changes made in the codebase.Overall, these changes bring a shift towards more secure and efficient ways of managing service configurations, contributing to an improved code quality and enhanced application reliability.